Mathtext tutorial fixes#12149
Merged
Merged
Conversation
anntzer
force-pushed
the
mathtext-tut
branch
2 times, most recently
from
fc588cc to
b15a24e
Compare
NelleV
reviewed
Sep 18, 2018
NelleV
left a comment
NelleV
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
I've added some oxford commas and capitalization of Matplotlib. Will merge once the CI passes!
Contributor
Author
|
yay, to, oxford, commas, |
NelleV
approved these changes
Sep 18, 2018
timhoffm
reviewed
Sep 18, 2018
| ----------------------------------------- | ||
|
|
||
| Fractions, binomials and stacked numbers can be created with the ``\frac{}{}``, | ||
| Fractions, binomials, and stacked numbers can be created with the ``\frac{}{}``, |
Member
There was a problem hiding this comment.
Line too long with the comma 😄
Member
There was a problem hiding this comment.
I'm now wondering if I should use the github interface or give up on being lazy and clone the code…
Member
There was a problem hiding this comment.
decision postponed after the coffee break ☕
- Remove reference to (obsolete) narrow python builds. - Quote a string.
- Switch from part-string, part-comment to a single large string. - Reflow to 79 characters wide.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 4, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 4, 2018
jklymak
added a commit
that referenced
this pull request
Oct 4, 2018
…149-on-v3.0.x Backport PR #12149 on branch v3.0.x (Mathtext tutorial fixes)
jklymak
added a commit
that referenced
this pull request
Oct 5, 2018
…149-on-v3.0.0-doc Backport PR #12149 on branch v3.0.0-doc (Mathtext tutorial fixes)
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Feb 12, 2019
Mathtext tutorial fixes
Conflicts:
.flake8
- does not exist on this branch
tutorials/text/mathtext.py
- keep all backported changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I'd suggest reviewing the two commits separately :p
Preliminary work to a proper fix of #12108 / #12128
PR Checklist