Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.#12128
Conversation
anntzer
force-pushed
the
sphinx18math
branch
from
6f1f505 to
40a7742
Compare
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Wow great. The only question I’d have is why we can’t use the Sphinx math directive, it I can believe they are different enough to make that a PITA
|
We can (and this PR basically does that implicitly by keeping :math: on the rest of the docs, which will use sphinx's math role), except for the mathtext tutorial because it uses mathtext construct that are not actually valid latex (\mathcircled, #7710 (comment)). My long term plan proposal is to rewrite the mathtext tutorial to just use the .. plot:: instead and completely kill :mathmpl: (even if you're using older versions of sphinx they also provide :math:, you just needed to add sphinx.ext.pngmath to the extensions list instead of being active by default). This PR is just a stopgap fix. |
|
Something went wrong ... Please have a look at my logs. |
FIX: Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.
|
In the Writing mathematical expressions tutorial there are now strange red symbols appearing
which have not been there in the previous version. Is this a consequence of this PR? |
FIX: Unbreak the Sphinx 1.8 build by renaming :math: to :mathmpl:.
Conflicts:
lib/matplotlib/sphinxext/mathmpl.py
- import cleanups
4 participants
PR Summary
Would be kind of nice to have for 3.0, but heh.
PR Checklist