Skip to content

BUG: make arg 'N' and kwarg 'levels' behave the same when scalar - #11917

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
efiring:contour_level_kwarg_scalar
Aug 23, 2018
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
efiring:contour_level_kwarg_scalar

Conversation

@efiring

@efiring efiring commented Aug 23, 2018

Copy link
Copy Markdown
Member

Closes #11913

PR Summary

PR Checklist

  • [ X] Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.0 milestone Aug 23, 2018
@jklymak
jklymak merged commit 7b5ff33 into matplotlib:master Aug 23, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 23, 2018
QuLogic added a commit that referenced this pull request Aug 23, 2018
@jklymak

jklymak commented Mar 4, 2019

Copy link
Copy Markdown
Member

@meeseeksdev backport to v2.2.x

@lumberbot-app

lumberbot-app Bot commented Mar 4, 2019

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7b5ff33daa955f5be46da6af823c031524164857
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am "Backport PR #11917: BUG: make arg 'N' and kwarg 'levels' behave the same when scalar"
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-11917-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #11917 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jklymak added a commit to jklymak/matplotlib that referenced this pull request Mar 4, 2019
…scalar

BUG: make arg 'N' and kwarg 'levels' behave the same when scalar
@jklymak jklymak mentioned this pull request Mar 4, 2019
6 tasks
jklymak added a commit that referenced this pull request Mar 4, 2019
* Backport from master
@dstansby dstansby modified the milestones: v3.0.0, v3.1.0 Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plt.contour levels parameter don't work as intended if receive a single int

4 participants