Skip to content

Simplify linestyle and fillstyle reference docs. - #11909

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:styleref-docs
Aug 22, 2018
Merged

jklymak merged 1 commit into
matplotlib:masterfrom
anntzer:styleref-docs

Conversation

@anntzer

@anntzer anntzer commented Aug 21, 2018

Copy link
Copy Markdown
Contributor

I don't know what's up with "cornflowerblue" but "tab:blue" is just as
good :)

xref #11908

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@afvincent

Copy link
Copy Markdown
Contributor

Not sure that tab:blue existed when the doc has been originally written ;).

@anntzer

anntzer commented Aug 21, 2018

Copy link
Copy Markdown
Contributor Author

sure but "blue" did...

@afvincent

Copy link
Copy Markdown
Contributor

Yep, and as "red" and "green", some people find such color a bit too aggressive to the eyes, while "cornflowerblue" is a bit more pastel-ish IIRC ^^.

from matplotlib.lines import Line2D


points = np.ones(5) # Draw 3 points for each line

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does draw 5 points and not 3 as the comment states, does it not?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... sure

I don't know what's up with "cornflowerblue" but "tab:blue" is just as
good :)
@jklymak
jklymak merged commit d384595 into matplotlib:master Aug 22, 2018
@jklymak jklymak added this to the v3.1 milestone Aug 22, 2018
@anntzer
anntzer deleted the styleref-docs branch August 22, 2018 17:09
@tacaswell

Copy link
Copy Markdown
Member

"cornflowerblue" is more whimsical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants