Skip to content

DOC: make ibm link go to doi not ieee site#11881

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:doc-colormap-doi
Aug 19, 2018
Merged

DOC: make ibm link go to doi not ieee site#11881
QuLogic merged 1 commit into
matplotlib:masterfrom
jklymak:doc-colormap-doi

Conversation

@jklymak

@jklymak jklymak commented Aug 18, 2018

Copy link
Copy Markdown
Member

PR Summary

Just a quick follow up to #11799 to make the link go to the doi look up. We really should do this when possible because maintaining the canonical link becomes doi.org's problem, not ours. The link resolves to the same spot.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v2.2-doc milestone Aug 18, 2018
@QuLogic QuLogic merged commit e5d5d40 into matplotlib:master Aug 19, 2018
@lumberbot-app

lumberbot-app Bot commented Aug 19, 2018

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.3-doc
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e5d5d4028a03b315dc8c8d87e0680c6e3e57530c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #11881: DOC: make ibm link go to doi not ieee site'
  1. Push to a named branch :
git push YOURFORK v2.2.3-doc:auto-backport-of-pr-11881-on-v2.2.3-doc
  1. Create a PR against branch v2.2.3-doc, I would have named this PR:

"Backport PR #11881 on branch v2.2.3-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Aug 19, 2018
DOC: make ibm link go to doi not ieee site
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Nov 9, 2018
DOC: make ibm link go to doi not ieee site
@tacaswell tacaswell mentioned this pull request Nov 9, 2018
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Nov 10, 2018
DOC: make ibm link go to doi not ieee site
tacaswell added a commit that referenced this pull request Nov 10, 2018
DOC: Backport colormap documentation

Includes  #11905, #11799, #11881, and #12084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants