Repository navigation
Update vendored jquery - #11768
Update vendored jquery#11768dstansby wants to merge 2 commits into
Conversation
anntzer
left a comment
There was a problem hiding this comment.
That basically defeats the point mentioned in #11199 (comment), repeated here for convenience:
Right now jquery weights 1.3Mb; compare this with the baseline test images that weight ~50Kb each and that we are painstakingly trying to avoid adding to the repo.
|
Fair point, just to see what happens I've updated to the latest 1.x version in a way that should be a diff and not a file replace. I suspect the diff is still too large though. |
|
This missing a number of places the names need to be changed: On the call we decided to go with this (despite the concerns about size) for expediency and trusting git's compression. |
|
We should also verify that this actually fixes the CVEs against jquery. |
|
I favor keeping the part of this PR that switches to using the unversioned name. |
|
We also need to update jquery-ui as that is what the CVE in #11199 is actually against. |
|
Does this need to be urgently fixed? The CVE has been opened for more than 1y now, I don't see why this would have become urgent all of a sudden. |
|
Yeah, replacing jquery-ui too makes this a bit of a large diff.. |
|
Closing in favor of #11246 |
Simple fix for #11199, whilst #11246 is being discussed.