Repository navigation
Fix cairo's image inversion and alpha misapplication. - #11724
Merged
Merged
Conversation
tacaswell
approved these changes
Jul 23, 2018
Member
|
So there is no test for this? |
Contributor
Author
|
No CI. |
jklymak
approved these changes
Jul 26, 2018
Member
|
@meeseeksdev backport to v2.2.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Member
|
This did not get backported to 2.2.x, but did make it in to 3.0.0, re-milestoned as such. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #8798. Looks like people are actually using the backend and running into the bug :p
I guess this would be nice to have in 3.0 (as it fixes a pretty bad bug) but won't insist on it either.
PR Checklist