Remove some extra spaces in docstrings/comments.#11592
Merged
Merged
Conversation
jklymak
approved these changes
Jul 7, 2018
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
.... I'm not going to ask how you found all these...
Member
|
Merging because I don't think any code was touched... |
afvincent
reviewed
Jul 7, 2018
|
|
||
| def get_width(self): | ||
| "Return the width of the rectangle" | ||
| "Return the width of the rectangle" |
Contributor
There was a problem hiding this comment.
Add a final period ? As you seem to have added it to other docstrings (at least one) 😈.
| angle = np.abs(np.mod((alpha2-alpha1) / np.pi, 1.)) | ||
| # Weight proportional to angle up np.pi/2 ; null weight for | ||
| # Weight proportional to angle up np.pi/2; null weight for | ||
| # degenerated cases 0. and np.pi (Note that `angle` is normalized |
Contributor
There was a problem hiding this comment.
Being there "degenerated cases 0 and np.pi (note that angle is normalized"?
Member
|
.... sorry |
Contributor
|
@jklymak No problem 😄. (BTW, I would be interested to know how all those extra spaces were found ^^...) |
Contributor
Author
|
I noticed one while checking the signature of cbook.deprecated (for #11590). Then it just a matter of grepping for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist