Add private API retrieving the current event loop and backend GUI info.#11520
Merged
Conversation
anntzer
added
the
Release critical
tacaswell
reviewed
Jun 29, 2018
| if not line.startswith(' File "<frozen importlib._bootstrap')) | ||
|
|
||
|
|
||
| def _get_current_event_loop(): |
Member
There was a problem hiding this comment.
This should be something like _get_interactive_framework_name. _get_current_event_loop makes me think it will return to me an object I can use as an event loop (ala asyncio.get_event_loop()).
Member
|
I like the direction this is heading. |
anntzer
force-pushed
the
getcurrenteventloop
branch
from
f1e925f to
8bb7bea
Compare
Contributor
Author
|
Comment handled, and documented the edit: As for tests, I'll probably have something globally testing switchability once everything gets in (e.g. together with the last commit). |
Work towards implementation of backend switching. Note that the API is kept private for now as the lack of extensibility is a bit unsatisfying; perhaps we'll figure out a better way to do it if other custom implementers (e.g., code editors?) get interested in looking into it. The `required_event_loop` variable could be made private for now, or not...
anntzer
force-pushed
the
getcurrenteventloop
branch
from
8bb7bea to
93ebee6
Compare
tacaswell
approved these changes
Jul 1, 2018
efiring
approved these changes
Jul 3, 2018
efiring
left a comment
efiring
left a comment
Member
There was a problem hiding this comment.
I don't understand every detail, but overall it looks fine, and I don't see how it could hurt anything.
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards implementation of backend switching (#9795).
Note that the API is kept private for now as the lack of extensibility
is a bit unsatisfying; perhaps we'll figure out a better way to do it
if other custom implementers (e.g., code editors?) get interested in
looking into it.
The
required_event_loopvariable could be made private for now, ornot...
PR Summary
PR Checklist