Skip to content

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 23, 2018

PR Summary

wxpython installation was silently failing in CI recently, see e.g. from https://travis-ci.org/matplotlib/matplotlib/jobs/395893835#L1537.

This PR should fix it (basically allowing pip to find the dependency on pypi). TBH I don't remember why I originally put the --no-index...

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
Contributor Author

anntzer commented Jun 24, 2018

(other build issues remain but at least wxpython is properly installed, see https://travis-ci.org/matplotlib/matplotlib/jobs/395953339#L1549)

@efiring efiring merged commit eaf94d2 into matplotlib:master Jul 4, 2018
@anntzer anntzer deleted the wxpy branch July 4, 2018 11:50
@QuLogic QuLogic added this to the v3.0 milestone Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants