Skip to content

Hyperlink DOIs against preferred resolver - #11470

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
katrinleinweber:resolve-DOIs-securely
Jun 21, 2018
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
katrinleinweber:resolve-DOIs-securely

Conversation

@katrinleinweber

@katrinleinweber katrinleinweber commented Jun 21, 2018 •

Copy link
Copy Markdown
Contributor

PR Summary

The DOI foundation recommends this new resolver. Yes, a bit ironic that they would change the URL of their service, but it's now encrypted. Because the old links with the dx subdomain continue to work, there is no urgent need to do anything.

However, I'd hereby like to suggest to follow the new recommendation and update all static DOI links.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@dstansby dstansby added this to the v3.0 milestone Jun 21, 2018

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@dstansby
dstansby merged commit be38fc7 into matplotlib:master Jun 21, 2018
@katrinleinweber

Copy link
Copy Markdown
Contributor Author

You're welcome, and thanks for merging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants