Repository navigation
Pin pytest-timeout to fix the build. - #11444
Merged
Merged
Conversation
jklymak
previously approved these changes
Jun 15, 2018
jklymak
left a comment
Member
There was a problem hiding this comment.
LGTM. Is there a reason we pin pytest?
Member
|
That test case is running minimum (almost) everything. |
jklymak
dismissed
their stale review
June 15, 2018 22:09
Guess it should pass the breaking test first ;-)
anntzer
force-pushed
the
pin-pytest-timeout
branch
from
June 15, 2018 22:13
8e29b1c to
7b45c37
Compare
anntzer
force-pushed
the
pin-pytest-timeout
branch
from
June 18, 2018 20:13
7b45c37 to
945c016
Compare
Contributor
Author
|
Now fixed (needed to work around the fact that travis installs a not-up-to-date pytest by default). |
jklymak
approved these changes
Jun 18, 2018
phobson
approved these changes
Jun 18, 2018
Member
|
@meeseeksdev backport to v2.2.x |
Member
|
I assume that backport is going to fail, but I suspect we are going to have the same issues on the 2.2.x branch... |
|
There seem to be a conflict, please backport manually |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 22, 2018
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 22, 2018
Pin pytest-timeout to fix the build.
Member
|
Backport at #11478. |
jklymak
added a commit
that referenced
this pull request
Jun 22, 2018
Backport of #11444 to v2.2.2-doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
See https://gitter.im/matplotlib/matplotlib?at=5b23860732618e705ebca4ed and below.
PR Checklist