Doc: Remove huge note box from examples.#11428
Merged
jklymak merged 1 commit intoJun 12, 2018
Merged
Conversation
jklymak
approved these changes
Jun 12, 2018
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
LGTM. I'm going to merge. If someone objects we can revisit, but I don't think the big Note looks good, and is redundant with our buttons below the examples
ImportanceOfBeingErnest
deleted the
doc_remove-huge-note-box-from-examples
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sphinx-gallery introduced a Note-Box on top of all examples linking to the bottom of each page from where to download the code.
I find this unnecessary and disturbing. After all, a page should start with its title, not a note. Since there is no way to move that box somewhere else, my proposal is to remove it entirely.