DOC: point align-ylabel demo to new align-label functions#11424
Conversation
jklymak
force-pushed
the
doc-align-ylabels
branch
2 times, most recently
from
097ad89 to
2fecd9b
Compare
ImportanceOfBeingErnest
left a comment
ImportanceOfBeingErnest
left a comment
There was a problem hiding this comment.
Many examples indeed lack proper cross linking to similar/opposite/related cases. This is a step in the right direction.
|
tbh I find the two big boxes on top a bit... too much. How did the Note box get introduced anyways? Can we get rid of that? I mean the page should start with its title, not with a note.
|
|
I didn't introduce that! sphinx-gallery maybe? EDIT: WRT the second blue box, I think its justified - the new methods are much easier for most uses... |
|
I’d rather have See also sections below the code. Having it up the is like saying “I’ll show you how to do alignment, but first you should look at these alternative ways. Then again the referenced method is the simpler more standard case, which should come first. The best solution would be to rewrite the example: First show a simple ˋalign_ylabel()ˋ example, then show the current code in case someone needs more control. But I do not necessarily require this as part of this PR. Mentioning ˋalign_ylabel()ˋ is an improvement already. |
|
Well ok fair enough. On phone and can’t label but I agree that combining the examples is a better solution. So please don’t merge until I do that. |
jklymak
force-pushed
the
doc-align-ylabels
branch
3 times, most recently
from
7807912 to
9adb067
Compare
jklymak
force-pushed
the
doc-align-ylabels
branch
2 times, most recently
from
3c27acc to
0edc77c
Compare
jklymak
force-pushed
the
doc-align-ylabels
branch
from
0edc77c to
07501bd
Compare
|
@timhoffm are the changes ok? If so, we can merge... |
|
There seem to be a conflict, please backport manually |
|
Not a big deal to bother w/ backport... Thanks @timhoffm! |
4 participants
PR Summary
https://matplotlib.org/gallery/pyplots/align_ylabels.html#sphx-glr-gallery-pyplots-align-ylabels-py shows a hard way to do whats in https://matplotlib.org/gallery/subplots_axes_and_figures/align_labels_demo.html#sphx-glr-gallery-subplots-axes-and-figures-align-labels-demo-py
The hard way is potentially useful, but the easy way should at least be referenced.