Repository navigation
FIX: better default spine path (for logit) - #11417
Conversation
|
@dstansby Thanks,; new test fails on master, passes on this PR. |
9f38fd6 to
e213f4b
Compare
dstansby
left a comment
There was a problem hiding this comment.
Seems like a bit of a bodge that should be fixed properly elsewhere, but if it works it works for now.
|
Hmmm, well, the problem is The other solution that occured to me is getting the spine Path to resolve itself properly earlier, but that seemed hard, and unecessary. |
|
I should probably write a similar test for mpl-probscale, which is very similar to logit scales |
PR Summary
Closes #11386; see also #11404 which fixes the errors for tight_layout and constrained_layout.
gives a warning, and does not show the ylabel. Issue is that the yaxis spine path is
and
_update_label_positionneeds a valid path to get started, whereas the logit scale injects Infs.This PR changes the default PATH to something that would theoretically fit on the figures (and hence all values are less than 1).
PR Checklist