Skip to content

Patch intel - #11356

Closed
s-sajid-ali wants to merge 2 commits into
matplotlib:masterfrom
s-sajid-ali:patch_intel
Closed

s-sajid-ali wants to merge 2 commits into
matplotlib:masterfrom
s-sajid-ali:patch_intel

Conversation

@s-sajid-ali

@s-sajid-ali s-sajid-ali commented May 31, 2018 •

Copy link
Copy Markdown

PR Summary

closes 11340

Changes poly2.c to build with intel compiler.

@anntzer

anntzer commented May 31, 2018

Copy link
Copy Markdown
Contributor

I think the patch should be upstreamed and then we can update the vendored version of qhull (perhaps keeping a similar approach as #11246 in mind).

@s-sajid-ali

Copy link
Copy Markdown
Author

Looks like upstream isn't active, but I've raised an issue about the patch. I'm a little confused as to why qhull itself builds but the matplotlib extension won't build.

@tacaswell

Copy link
Copy Markdown
Member

@s-sajid-ali I was suggesting you put the patch in your spak recipe, I strongly suspect that the spak package for qhull is already carrying such a patch.

I am skeptical of merging this for the same reason as @anntzer , but leave the final decision to @ianthomas23 .

@s-sajid-ali

Copy link
Copy Markdown
Author

Okay, I misunderstood that part. I'll see if the issue I opened upstream gets any response and if that fails see if it can be fixed within spack.

@tacaswell tacaswell added this to the v3.1 milestone Aug 27, 2018
@anntzer

anntzer commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

Actually looking at this again the issue appears to arise because you are compiling poly2.c using icpc (intel c++ compiler) as opposed to icc (intel c compiler). On a bland linux install this file is correctly compiled by gcc, not g++. (And indeed, assigning the result of malloc without a cast is valid C, not valid C++.)

Thus I think the fix is actually on spack's side (or whoever set up the compilation machinery to use icpc/icc).

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing to close per #11356 (comment).

@tacaswell tacaswell removed this from the v3.1 milestone Sep 18, 2018
@tacaswell

Copy link
Copy Markdown
Member

I agree with @anntzer , this should be fixed on the spack side (either to fix the compiler selection, to find the system qhull, or to carry the patch).

@tacaswell tacaswell closed this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matplotlib fails to install from source with intel compiler

3 participants