Skip to content

Use GtkShortcutsWindow for Help tool. - #11085

Merged
dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:helptool-gtk3
Apr 22, 2018
Merged

dstansby merged 1 commit into
matplotlib:masterfrom
QuLogic:helptool-gtk3

Conversation

@QuLogic

@QuLogic QuLogic commented Apr 19, 2018 •

Copy link
Copy Markdown
Member

PR Summary

A followup to #11045, using GTK's builtin widgets for shortcuts, when they are available. I also applied a small hack of putting every shortcut in its own group, because then GTK automatically splits columns and pages.
screenshot from 2018-04-18 22-32-15

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.0 milestone Apr 19, 2018
@jklymak

jklymak commented Apr 19, 2018

Copy link
Copy Markdown
Member

I guess its not this PR, but can the 1/2/3/4... be changed to 1-9 or something?

@QuLogic

QuLogic commented Apr 19, 2018

Copy link
Copy Markdown
Member Author

All the shortcuts are added to the widget and the / and other formatting is added by GTK automatically. If you wanted to coalesce like that, it'd be an enhancement for the GTK widget, I think.

@dstansby
dstansby merged commit 41a81c0 into matplotlib:master Apr 22, 2018
@QuLogic
QuLogic deleted the helptool-gtk3 branch April 22, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants