Repository navigation
FIX: return proper legend window extent - #10910
Merged
phobson merged 2 commits intoApr 8, 2018
Merged
Conversation
tacaswell
approved these changes
Mar 28, 2018
jklymak
force-pushed
the
fix-proper-legend-window-extent
branch
from
March 28, 2018 20:36
3b27337 to
9a03a2d
Compare
Member
Author
|
Bump - this is a pretty straightforward one that fixes at least one reported issue |
phobson
approved these changes
Apr 8, 2018
Member
Author
|
Thanks @phobson |
This was referenced Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As per #10844, it was not possible to properly use
text.OffsetFromif the artist was alegend. The issue was thatlegend.get_window_extentwas calling the wrong patch object to get the patch location.The following code now returns properly placed text regardless of the savefig dpi:
PR Checklist