Repository navigation
Added feature (Make pie charts circular by default #10789) - #10887
Closed
jerryluicy wants to merge 8 commits into
Closed
jerryluicy wants to merge 8 commits into
jerryluicy wants to merge 8 commits into
Conversation
Member
|
@jerrylui803 Thanks! Could you please squash this to one commit and add a test so it does not break again in the future? xref #10789 |
Member
|
You should also change the docstring to say that it is setting the aspect ratio. |
Contributor
Author
|
Will do, I'll delete this and make a new pull request |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
github.com//issues/10789
As seen in the issue link above, a simple way to generate a pie graph is using plt.pie, and the second method to generate a pie graph is by using plt.subplots. Both of these approaches creates the pie graph through _axes.py by using an Axes instance which calls its pie method; the additional line to add calls the set_aspect function, which sets the aspect of the axis scaling, with ‘equals’ as parameters and this results in a default circular pie graph with an equal aspect ratio as wanted.
Here is the travis test: https://travis-ci.org/jerrylui803/matplotlib/builds/358696515
PR Checklist