You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Run setupext qt checks in a subprocess rather than with multiprocessing. - #10886
#10885 needs to be merged too before removing multiprocessing (or I can rebase the later of the two PRs).
I think the impossibility of importing qt4 and qt5 in the same process is due to C symbol clash(?), so that's not a problem with pyqt and pyside(?).
This will basically become obsolete once #11600 or a variant thereof gets merged (we won't be checking for the GUI toolkits during the build at all anymore).
I guess #11600 (or variant) should get in soon so I'll remilestone this away from 3.0 for now; I'll close this once #11600 goes in (it's not a problem either if this gets merged if #11600 ends up taking too long).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
(yes, having code as strings is a bit ugly, but less that having multiprocessing in setup.py...)
PR Checklist