Skip to content

Run setupext qt checks in a subprocess rather than with multiprocessing.#10886

Closed
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:setupext-qt
Closed

Run setupext qt checks in a subprocess rather than with multiprocessing.#10886
anntzer wants to merge 1 commit into
matplotlib:masterfrom
anntzer:setupext-qt

Conversation

@anntzer

@anntzer anntzer commented Mar 27, 2018

Copy link
Copy Markdown
Contributor

PR Summary

(yes, having code as strings is a bit ugly, but less that having multiprocessing in setup.py...)

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Mar 27, 2018
@tacaswell tacaswell added this to the v3.0 milestone Mar 27, 2018
@tacaswell

tacaswell commented Mar 27, 2018

Copy link
Copy Markdown
Member

Can you also remove the multiprocess import now?

Bit surprised that you can import both pyqt and pyside in one process.

@anntzer

anntzer commented Mar 27, 2018

Copy link
Copy Markdown
Contributor Author

#10885 needs to be merged too before removing multiprocessing (or I can rebase the later of the two PRs).
I think the impossibility of importing qt4 and qt5 in the same process is due to C symbol clash(?), so that's not a problem with pyqt and pyside(?).

@anntzer anntzer modified the milestones: v3.0, unassigned Jul 16, 2018
@anntzer

anntzer commented Jul 16, 2018

Copy link
Copy Markdown
Contributor Author

This will basically become obsolete once #11600 or a variant thereof gets merged (we won't be checking for the GUI toolkits during the build at all anymore).
I guess #11600 (or variant) should get in soon so I'll remilestone this away from 3.0 for now; I'll close this once #11600 goes in (it's not a problem either if this gets merged if #11600 ends up taking too long).

@anntzer

anntzer commented Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Obsoleted by #11962.

@anntzer anntzer closed this Aug 31, 2018
@anntzer anntzer deleted the setupext-qt branch August 31, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anntzer @tacaswell