Skip to content

Correctly display error when running setup.py test. - #10837

Merged
dopplershift merged 1 commit into
matplotlib:masterfrom
anntzer:setuppytesterror
Mar 19, 2018
Merged

dopplershift merged 1 commit into
matplotlib:masterfrom
anntzer:setuppytesterror

Conversation

@anntzer

@anntzer anntzer commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

We display an error if someone tries to run setup.py test (saying that
one should run tests.py instead), but that doesn't get displayed if
test.local_freetype is set in setup.cfg -- because the test command
considers that equivalent to passing a (non-existent) local_freetype
option to it, and fails first during argument parsing.

As a solution, display the error in the constructor of the command
instead.

Closes #8874.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

We display an error if someone tries to run setup.py test (saying that
one should run tests.py instead), but that doesn't get displayed if
test.local_freetype is set in setup.cfg -- because the test command
considers that equivalent to passing a (non-existent) local_freetype
option to it, and fails first during argument parsing.

As a solution, display the error in the constructor of the command
instead.
@anntzer anntzer added the Build label Mar 19, 2018
@dopplershift
dopplershift merged commit 3b915df into matplotlib:master Mar 19, 2018
@anntzer
anntzer deleted the setuppytesterror branch March 19, 2018 20:29
@QuLogic QuLogic added this to the v3.0 milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash in python setup.py test

4 participants