Skip to content

Propagate marker antialias setting to GraphicsContext. - #10833

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:marker-antialiasing
Mar 19, 2018
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:marker-antialiasing

Conversation

@anntzer

@anntzer anntzer commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

The Agg backend still doesn't know how to make use of that information
in draw_markers, but third-party backends (e.g. mplcairo) do honor the
setting.

xref #10825.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The Agg backend still doesn't know how to make use of that information
in draw_markers, but third-party backends (e.g. mplcairo) do honor the
setting.
@tacaswell tacaswell added this to the v3.0 milestone Mar 18, 2018
@timhoffm
timhoffm merged commit ccc35b0 into matplotlib:master Mar 19, 2018
@anntzer
anntzer deleted the marker-antialiasing branch March 19, 2018 00:45
@ImportanceOfBeingErnest

Copy link
Copy Markdown
Member

Does this solve #10825 ? If so, shouldn't the issue be closed? If not, what's left to solve it?

@anntzer

anntzer commented Mar 26, 2018

Copy link
Copy Markdown
Contributor Author

Only with mplcairo... so the issue should stay open (now Agg gets the info, but I think (TBC?) it doesn't take advantage of it).

@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 Aug 4, 2018
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Aug 4, 2018
Propagate marker antialias setting to GraphicsContext.
@tacaswell

Copy link
Copy Markdown
Member

backported to v2.2.x as 278ee47 to make #11105 backport cleanly.

Made an executive decision to backport explicitly rather than implicitly by resolving the conflict for #11105 (and keeping this line) or be annoyingly inflexible about backports and delete this line in the other backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants