Mark the qt5 interactive test as xfail.#10315
Closed
anntzer wants to merge 1 commit into
Closed
Conversation
Member
|
Can we use the old version of Qt instead of xfail? |
Contributor
Author
|
dunno if it's a qt version problem or something else, feel free to investigate and close this if your solution works. |
Member
|
Yeah it was a qt version change. 5.9 works fine. |
Contributor
Author
|
closed in favor of #10316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
will selfmerge if passes to unbreak the build
probably worth using strict xfail later too
PR Checklist