Repository navigation
FIX: (re-allow) legend OrderedDict handles and labels... - #10263
Merged
Merged
Conversation
anntzer
previously requested changes
Jan 16, 2018
| else: | ||
| _lab.append(label) | ||
| _hand.append(handle) | ||
| label, handle = _lab, _hand |
Member
Author
There was a problem hiding this comment.
That certainly fixed it alright ;-)
jklymak
force-pushed
the
fix-legend-ordereddict
branch
from
January 16, 2018 23:51
9cc2506 to
3d65ca1
Compare
tacaswell
approved these changes
Jan 17, 2018
dstansby
approved these changes
Jan 17, 2018
|
There seem to be a conflict, please backport manually |
tacaswell
added a commit
that referenced
this pull request
Jan 18, 2018
FIX: (re-allow) legend OrderedDict handles and labels...
Conflicts:
lib/matplotlib/legend.py
- conflicts on patch, kept backported version
Member
|
backported to v2.1.x as c125ab4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As reported in #10262, OrderedDict input no longer works in 2.1.1. i.e.
This PR fixes that (thanks @anntzer) and adds a small test...
PR Checklist