Skip to content

Updated what's new entry for color comparision method - #10146

Merged
dstansby merged 3 commits into
matplotlib:masterfrom
surana-mudit:master
Jan 8, 2018
Merged

dstansby merged 3 commits into
matplotlib:masterfrom
surana-mudit:master

Conversation

@surana-mudit

@surana-mudit surana-mudit commented Jan 3, 2018 •

Copy link
Copy Markdown
Contributor

Issue #10069

PR Summary

I have updated the what's new entry for the color comparision method. I think we can close the old PR #10071

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Comparision of 2 colors in Matplotlib
-------------------------------------

As the colors in Matplotlib can be specified with a wide variety of ways, this new version consists of a method ``matplotlib.colors.same_color`` which allows 2 legend colors to be compared.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use single ticks so this generates a link.

The English is a bit convoluted..:

New method `matplotlib.colors.same_color` checks if  two `~matplotlib.colors` are the same.  

@QuLogic QuLogic added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jan 3, 2018
@QuLogic QuLogic added this to the v2.2 milestone Jan 3, 2018
@QuLogic
QuLogic requested a review from dstansby January 3, 2018 23:35
@surana-mudit

Copy link
Copy Markdown
Contributor Author

@jklymak I am not able to find any way to generate link to the method. I have also tried your idea but its not working.

@dstansby

dstansby commented Jan 4, 2018

Copy link
Copy Markdown
Member

Sphinx error seems unrelated, if someone merges this please can it be squashed.

@surana-mudit

Copy link
Copy Markdown
Contributor Author

@dstansby @jklymak any updates on this PR?

@dstansby
dstansby merged commit 1c3a02b into matplotlib:master Jan 8, 2018
@dstansby

dstansby commented Jan 8, 2018

Copy link
Copy Markdown
Member

Thanks a lot!

@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants