Skip to content

fix for bug #996 and related issues - #1011

Merged
efiring merged 1 commit into
matplotlib:masterfrom
mdehoon:fix_for_issue_996
Jul 15, 2012
Merged

efiring merged 1 commit into
matplotlib:masterfrom
mdehoon:fix_for_issue_996

Conversation

@mdehoon

@mdehoon mdehoon commented Jul 15, 2012

Copy link
Copy Markdown
Contributor

This is a fix for bug #996 (macosx backend broken by #901: QuadMesh fails so colorbar fails) and a few related issues.

efiring added a commit that referenced this pull request Jul 15, 2012
@efiring
efiring merged commit 408c529 into matplotlib:master Jul 15, 2012

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know its been merged already, but its worth mentioning that the lines:

if offset_position=='data':
    offset_position = True
else:
   offset_position = False

are exactly equivalent to:

offset_position = (offset_position=='data')

(un-necessary parentheses added for readability)

@pelson

pelson commented Jul 16, 2012

Copy link
Copy Markdown
Member

Out of interest, is the OSX backend purely graphical or would it be possible to add some unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants