Repository navigation
What's new entry for color comparision method - #10071
surana-mudit wants to merge 5 commits into
Conversation
|
@dstansby I have added a summary according to my understanding , please tell me if you want me to add something more. |
|
@dstansby could you please review it |
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Usually, you would reference the new method. In this case its matplotlib.colors.same_color
Wide variety of colors is vague: "colors in Matplotlib can be specified with a wide variety of ways..."
| Comparision of 2 colors in Matplotlib | ||
| ------------------------------------- | ||
|
|
||
| As Matplotlib comes with a wide variety of colors, therefore this new version allows 2 legend colors to be compared. |
There was a problem hiding this comment.
- The sentence doesn't quite sound right - I would just remove 'therefore'
- As @jklymak , could you reference the actual method by adding
`~matplotlib.colors.same_color`
This will show up as a link that says "same_color"
There was a problem hiding this comment.
A style thing, but I somewhat favour the full names so that users can see what modules routines come from?
There was a problem hiding this comment.
Yeah, that's a good point, if you could use this instead:
`matplotlib.colors.same_color`
dstansby
added
the
Release critical
|
ping @surana-mudit |
|
Please squash-merge this when it is merged. |
|
@surana-mudit This seems to have been messed up somehow. Can you check that it now does what you want (for instance, the Requested Changes are not showing up). |
|
I am extremely sorry for the late response. |
Issue #10069
PR Summary
I have added a new file to 'doc/users/next_whats_new' folder for the color comparision method.
PR Checklist