Add missing decode() in svg font embedding path. #10046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise,
rcParams["svg.fonttype"] = "svgfont"; title("foo"); savefig("/tmp/test.svg")
fails (on Py3) with
File ".../backend_svg.py", line 86, in escape_attrib
s = s.replace("&", "&")
TypeError: a bytes-like object is required, not 'str'
The encoding of entry 1, 0, 0, 4 in the sfnt table is macroman
(https://www.freetype.org/freetype2/docs/reference/ft2-truetype_tables.html#TT_MAC_ID_XXX).
Note that after the fix is applied, the resulting svg file still appears
to be unopenable by inkscape, so the fix is not complete, but hopefully
a step in the correct direction.
Member
|
Can you use |
Contributor
Author
|
done |
Member
|
I have also been reading it as 'macro-man' and puzzling at why they would come up with that name! |
QuLogic
approved these changes
Dec 28, 2017
dstansby
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
fails (on Py3) with
The encoding of entry 1, 0, 0, 4 in the sfnt table is macroman
(https://www.freetype.org/freetype2/docs/reference/ft2-truetype_tables.html#TT_MAC_ID_XXX).
Note that after the fix is applied, the resulting svg file still appears
to be unopenable by inkscape, so the fix is not complete, but hopefully
a step in the correct direction.
Of course, this suggests that the svg.fonttype = svgfont codepath is untested, which is another problem :p
In practice it appears that the svg font standard isn't that popular or well supported, see https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/SVG_fonts.
PR Summary
PR Checklist