Skip to content

MacOS: Key modifiers deprecated #9837

New issue
New issue
Closed
#21512
Closed
MacOS: Key modifiers deprecated#9837
#21512
Labels
GUI: MacOSX
Milestone
v3.6.0

Description

@jklymak
jklymak
opened on Nov 22, 2017

Bug report

Issue

A heads up that modifiers like:

matplotlib/src/_macosx.m

Lines 2601 to 2607 in 813d842

NSMutableString* returnkey = [NSMutableString string];
if ([event modifierFlags] & NSControlKeyMask)
[returnkey appendString:@"ctrl+" ];
if ([event modifierFlags] & NSAlternateKeyMask)
[returnkey appendString:@"alt+" ];
if ([event modifierFlags] & NSCommandKeyMask)
[returnkey appendString:@"cmd+" ];

are deprecated:

https://developer.apple.com/documentation/appkit/nseventmodifierflags?language=objc

and probably need to be replaced by the flags like NSEventModifierFlagCommand etc.

I'd change, but I'm not sure how this will affect older OS X installs etc...

Activity

  1. jklymak
    added
    GUI: MacOSX
    on Nov 22, 2017
  2. tacaswell
    added this to the milestone on Nov 22, 2017
  3. greglucas
    closed this as completedin #21512on Nov 30, 2021
  4. QuLogic
    modified the milestones: needs sorting, v3.6.0 on Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GUI: MacOSX

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions