Skip to content

Deprecate assert_str_equal #8112

Closed
Closed

Description

@dstansby

Judging by codecov, assert_str_equal in tests/__init__.py is never used (https://codecov.io/gh/matplotlib/matplotlib/src/master/lib/matplotlib/tests/__init__.py#L22), and grep agrees:

$ grep -r 'assert_str_equal' lib/
lib//matplotlib/tests/__init__.py:def assert_str_equal(reference_str, test_str,

So I don't see why it shouldn't be deprecated and then removed.

Activity

  1. tacaswell commented on Feb 20, 2017

    @tacaswell
    Member

    I think there may be a PR in flight to do that, possibly from @dopplershift ?

  2. added this to the milestone on Feb 20, 2017
  3. anntzer commented on Feb 21, 2017

    @anntzer
    Contributor

    I doubt so given that assert_str_equal was still in use until very recently (removed by @QuLogic in #8026).

  4. QuLogic commented on Feb 23, 2017

    @QuLogic
    Member

    Fixed by #8118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions