Skip to content

Hexbin default edgecolors kwarg is misnamed #7185

Closed

Description

@efiring

Hexbin has a default 'edgecolors' kwarg value of 'none', which it internally translates to 'face'. This is highly confusing and inconsistent, and it blocks the user from specifying 'none'. Granted, the 'none' value may be undesirable because of patch boundary artifacts, but it should not be interpreted as a completely different value.
The 'face' value is used to prevent artifacts by adding boundary lines. hexbin sets the default 'linewidths' to 1, which is probably much larger than it needs to be for this purpose, resulting in prominent artifacts when the number of hexagons is large.

Activity

  1. added
    API: consistencyConsistency of the matplotlib API, including naming, behavior, defaults, …
    on Sep 26, 2016
  2. added this to the milestone on Sep 26, 2016
  3. added
    Difficulty: Easyhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issues
    on Oct 10, 2016
  4. DrNightmare commented on Oct 30, 2016

    @DrNightmare
    Contributor

    It looks like someone has worked on fixing this issue quite some time back, although I'm not sure if they submitted a PR:
    tonysyu@39e2854
    I'm sure a lot of files changed since this commit, but the solution seems to hold: make 'edgecolors' default to 'face' to ensure backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API: consistencyConsistency of the matplotlib API, including naming, behavior, defaults, …Difficulty: Easyhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issues

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions