Values Return From Set Methods #7147

Activity

1. tacaswell

   added this to the 2.1 (next point release)This milestone has been deleted milestone on Sep 20, 2016
2. tacaswell commented on Sep 20, 2016

   

   tacaswell

   on Sep 20, 2016

   Member

   More actions

   Awesome you have come back to this! This went in as part of https://github.com/matplotlib/matplotlib/pull/5599/files

   I did that out of an abundance of caution to not change a different API. It looks like there are a handful of setters that do in fact return something.

   I do not see why they are incompatible:

   def set_foo(self, value):
       self.foo = value
       return self.foo

   but agree they should go long term.
3. rmorshea commented on Sep 20, 2016

   

   rmorshea

   on Sep 20, 2016

   Last edited by rmorshea

   ContributorAuthor

   More actions

   @tacaswell by "incompatible" I mean that if returning setters where an actual feature supported by matplotlib, there are certain setters that could not be replicated using traitlets.

   This kind of setter could be replicated with traitlets:

   def set_foo(self, value):
       new_value = change_it(value)
       self.foo = new_value
       return new_value

   However something like this could not:

   def set_foo(self, value):
       new_value, byproduct = change_it(value)
       self.foo = new_value
       return byproduct
4. tacaswell commented on Sep 21, 2016

   

   tacaswell

   on Sep 21, 2016

   Member

   More actions

   From a quick skim it looks like all of the returning setters return the same thing as their paired getter (ex set_title returns the Text object that is the title).

   If there are any in the second class I am nominally 👍 on deprecating / addressing on a case-by-case basis.
5. tacaswell

   modified the milestones: 2.1 (next point release)This milestone has been deleted, 2.2 (next next feature release)This milestone has been deleted on Oct 3, 2017
6. github-actions commented on Mar 29, 2023

   

   github-actionsBot

   on Mar 29, 2023

   More actions

   This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!
7. github-actions

   added

   status: inactiveMarked by the “Stale” Github ActionMarked by the “Stale” Github Action

   on Mar 29, 2023
8. github-actions

   closed this as not plannedon Apr 29, 2023
9. QuLogic

   removed this from the future releases milestone on May 2, 2023
10. rcomer

    added

    status: closed as inactiveIssues closed by the "Stale" Github Action. Please comment on any you think should still be open.Issues closed by the "Stale" Github Action. Please comment on any you think should still be open.

    on May 30, 2023