You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Image comparison decorator: symlinks to baseline images #6824
Currently image comparison decorator copies baseline image to result_images folder. Is not it better not to copy, but make symlink? With that change it still will be safe to remove result_images folder with rm -rf.
Matplotlib supports Windows XP? If not then Windows is not a problem.
Actually I have already developed cross-platform symlink support for image_comparison decorator with fallback to simple copy on unsupported platform, but it uses ctypes and gives not a big boost to testing time (around ~10 seconds)
As far as I remember the main problem is with symlinks within git repositories. That should not apply here. I am not sure about windows xp. We have not deliberately broken support for it but it's also not really tested.
I had some problems with git and links, but they were hard links to files or symlinks to folders (because you can easily wipe your original folder or files). That does no apply here at least because result_images does not belong to git repository.
Previously git-scm on windows was not aware of symlinks (from its point they were just regular files), so git checkout or git reset will give you no error and just replace/wipe content of symlinked file.
I do not know is it problem or not, but I think by default artifact tars will contain symlinks to baseline images (I believe there is some switches for this)
Just discovered @image_comparison and its a nice feature, but I'd like to be able to specify where the created images will be placed. Creating a result_images images in my project's root directory is not welcome.
Activity
jenshnielsen commentedon Jul 24, 2016
Sounds reasonable to me. We just need to ensure that this still runs correctly on all platforms
tacaswell commentedon Jul 26, 2016
symlinks do not play well with windows
Kojoley commentedon Jul 26, 2016
Matplotlib supports Windows XP? If not then Windows is not a problem.
Actually I have already developed cross-platform symlink support for
image_comparisondecorator with fallback to simple copy on unsupported platform, but it usesctypesand gives not a big boost to testing time (around ~10 seconds)jenshnielsen commentedon Jul 26, 2016
As far as I remember the main problem is with symlinks within git repositories. That should not apply here. I am not sure about windows xp. We have not deliberately broken support for it but it's also not really tested.
Kojoley commentedon Jul 26, 2016
I had some problems with git and links, but they were hard links to files or symlinks to folders (because you can easily wipe your original folder or files). That does no apply here at least because
result_imagesdoes not belong to git repository.tacaswell commentedon Jul 26, 2016
As a non-windows user I am greatly confused why the issues with links apply to git, but not here?
@Kojoley If you work on windows and this works for you then 👍 to links instead of copying.
Kojoley commentedon Jul 26, 2016
Previously git-scm on windows was not aware of symlinks (from its point they were just regular files), so
git checkoutorgit resetwill give you no error and just replace/wipe content of symlinked file.Kojoley commentedon Jul 26, 2016
I do not know is it problem or not, but I think by default artifact tars will contain symlinks to baseline images (I believe there is some switches for this)
jbrockmendel commentedon Dec 30, 2017
Just discovered
@image_comparisonand its a nice feature, but I'd like to be able to specify where the created images will be placed. Creating aresult_imagesimages in my project's root directory is not welcome.LMK if this belongs in a separate issue.
tacaswell commentedon Dec 30, 2017
@jbrockmendel You should have a look at pytest-mpl instead.
anntzer commentedon Jul 4, 2019
done in #10222.