Skip to content

Points annotation coords not working in 2.x #5994

Closed

Description

@QuLogic

See the annotation demo:
annotation_demo

Both "points" and "bottom right (points)" are in the wrong location.

Activity

  1. modified the milestones: , on Feb 13, 2016
  2. QuLogic commented on Feb 14, 2016

    @QuLogic
    MemberAuthor

    Oh, I knew I recognized this one from somewhere; it's caused by 7b71257 in 1.5.0. IIRC, this change is in fact desired, so probably the demo needs updating?

  3. tacaswell commented on Feb 16, 2016

    @tacaswell
    Member

    Yeah, I we should update the example

  4. dopplershift commented on May 17, 2016

    @dopplershift
    Contributor

    figure_1
    So points is fixed, but for me the color is different and local max is directly vertical above the point (though if I try to move it further, that works). Not sure what to do about the "bottom right (points)" case.

  5. dopplershift commented on May 17, 2016

    @dopplershift
    Contributor

    Oh, maybe blue color is only with new style?

  6. tacaswell commented on May 21, 2016

    @tacaswell
    Member

    For reference, this is what it looks like:


    1.3.1

    image


    1.5.1

    image


    1.5.x

    as built in docs

    image

    as run in a terminal

    so

    What corner of the 'local max' string the arrow hits is dpi/figure size dependent (it seems to be trying to do something smart and snaps to the closest corner.


    master

    image


    I am in the process of cleaning up this example (with slightly better text as well).

  7. added a commit that references this issue on May 21, 2016
    14db9f8
  8. self-assigned this
    on May 21, 2016
  9. tacaswell commented on May 21, 2016

    @tacaswell
    Member

    image

    in PR #6455

  10. added a commit that references this issue on May 21, 2016
    37eb2aa
  11. added a commit that references this issue on May 22, 2016
    3180fa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions