Skip to content

add xkcd style #5992

Open

Description

@WeatherGod

Can't believe we don't have this one already. Not perfectly trivial, as we would need a way to specify the special patheffect from the rcfile, but, essentially, this would replace plt.xkcd().

Should also look into finding an open font that we can package that matches Humor Sans.

Activity

  1. added this to the milestone on Feb 12, 2016
  2. souravsingh commented on Feb 28, 2016

    @souravsingh
    Contributor

    I would like to work on the issue.How do I start?

  3. jenshnielsen commented on Feb 28, 2016

    @jenshnielsen
    Member

    @souravsingh Awesome

    I suggest having a look at the existing styles (.sty) files in https://github.com/matplotlib/matplotlib/tree/master/lib/matplotlib/mpl-data/stylelib to see how they work.

    The code that defines the pyplot.xkcd is here: https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/pyplot.py#L353 so as a first step you can copy the rc params changes from there into a .sty file.

  4. modified the milestones: , on Feb 1, 2017
  5. added and removed
    Difficulty: Easyhttps://matplotlib.org/devdocs/devel/contribute.html#good-first-issues
    on Sep 16, 2017
  6. modified the milestones: , on Oct 3, 2017
  7. github-actions commented on Mar 21, 2023

    @github-actions

    This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

  8. rcomer commented on Mar 21, 2023

    @rcomer
    Member

    This still seems like something we should have.

  9. anntzer commented on Jun 26, 2023

    @anntzer
    Contributor

    @rcomer Perhaps we can decide whether we want to move forward with #14943 (or something along these lines) -- I don't really want to spend time arguing for it anymore. If we really don't want python style files, even restricted to matplotlib's own styles, then I think we should close this as effectively unfixable (because instantiating patheffects, even declaratively, necessarily means importing a python class and thus running arbitrary python code).

  10. timhoffm commented on Jun 26, 2023

    @timhoffm
    Member

    What could speak against python style files:

    • security: Users can inject arbitrary code. - IMHO there are various other ways to do this. (If it's really of concern, one could even guard this behind a flag)
    • API: With great power comes great responsibility. For public python style files we would need good instructions how to handle them.

    Both aspects do not apply as long as we keep python style files internal. - I think this is a good way forward a) to provide xkcd as style and b) to learn how python style files could be used without locking in on a certain API yet.

    Thus I support going forward with interal python style files. We can later decide whether we want to make this public as well.

  11. anntzer commented on Jun 26, 2023

    @anntzer
    Contributor

    OK, I rebased and reopened #14943, let's discuss that over there.

  12. github-actions commented on Jun 26, 2024

    @github-actions

    This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

  13. added
    keepItems to be ignored by the “Stale” Github Action
    and removed
    status: inactiveMarked by the “Stale” Github Action
    on Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions