Skip to content

test_backend.pgf.check_for(texsystem) does not do what it says... #5921

Closed

Description

@jankatins
def check_for(texsystem): #<- different commands are asked for, but not actually checked below...
    header = """
    \\documentclass{minimal}
    \\usepackage{pgf}
    \\begin{document}
    \\typeout{pgfversion=\\pgfversion}
    \\makeatletter
    \\@@end
    """
    try:
        latex = subprocess.Popen(["xelatex", "-halt-on-error"], #<- why not texsystem? 
                                 stdin=subprocess.PIPE,
                                 stdout=subprocess.PIPE)
        stdout, stderr = latex.communicate(header.encode("utf8"))
    except OSError:
        return False

    return latex.returncode == 0

Not sure if thats on purpose, but if so it should be documented...

Activity

  1. jenshnielsen commented on Feb 8, 2016

    @jenshnielsen
    Member

    I think this is a bug. I have fixed it as part of #5727 which still waits for Travis to approve cm-super before it can be merged.

  2. jenshnielsen commented on Feb 8, 2016

    @jenshnielsen
    Member

    @pwuertz does the change in 7d67737 make sense to you?

  3. pwuertz commented on Feb 8, 2016

    @pwuertz
    Contributor

    Right, this is a bug/typo in check_for()

  4. jenshnielsen commented on Feb 16, 2016

    @jenshnielsen
    Member

    fixed in #5727

  5. added this to the milestone on Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions