You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many downstream distro like fedora, debian, gentoo and so are using the pypi tarball, as this is what you are intending to ship to the end user. Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be a big deal to include that file. Currently we are running ${PYTHON} -c "import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)" but I really want to run the tests in the same way as you are doing it.
Fair enough. I am biased towards pulling directly from the tag on gh as it
is the ground truth, but I will not argue with packagers about packaging. (
I was just trying to be helpful and suggest work arounds for right now).
Unless this is a regression I don't think this is enough to force a new
release, but will be fixed in the next one.
Many downstream distro like fedora, debian, gentoo and so are using the
pypi tarball, as this is what you are intending to ship to the end user.
Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be
a big deal to include that file. Currently we are running ${PYTHON} -c
"import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)"
but I really want to run the tests in the same way as you are doing it.
—
Reply to this email directly or view it on GitHub #5831 (comment)
.
Activity
tacaswell commentedon Jan 11, 2016
Have we ever included
tests.pyin the pypi tarball?I suggest pulling the src tarball from gh instead?
jenshnielsen commentedon Jan 11, 2016
I suspected that it might have been removed in #4668 but that does not seem to be the case.
jlec commentedon Jan 11, 2016
Many downstream distro like fedora, debian, gentoo and so are using the pypi tarball, as this is what you are intending to ship to the end user. Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be a big deal to include that file. Currently we are running
${PYTHON} -c "import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)"but I really want to run the tests in the same way as you are doing it.tacaswell commentedon Jan 11, 2016
Fair enough. I am biased towards pulling directly from the tag on gh as it
is the ground truth, but I will not argue with packagers about packaging. (
I was just trying to be helpful and suggest work arounds for right now).
Unless this is a regression I don't think this is enough to force a new
release, but will be fixed in the next one.
On Mon, Jan 11, 2016, 07:56 Justin Lecher notifications@github.com wrote:
jlec commentedon Jan 11, 2016
no, that can be done in the next release. thanks.
BLD: include tests.py in sdist
BLD: include tests.py in sdist