Skip to content

tests.py is missing from pypi tarball #5831

Closed

Description

@jlec

Please include tests.py so that downstream maintainers can properly test.

Activity

  1. added this to the milestone on Jan 11, 2016
  2. tacaswell commented on Jan 11, 2016

    @tacaswell
    Member

    Have we ever included tests.py in the pypi tarball?

    I suggest pulling the src tarball from gh instead?

  3. jenshnielsen commented on Jan 11, 2016

    @jenshnielsen
    Member

    I suspected that it might have been removed in #4668 but that does not seem to be the case.

  4. jlec commented on Jan 11, 2016

    @jlec
    Author

    Many downstream distro like fedora, debian, gentoo and so are using the pypi tarball, as this is what you are intending to ship to the end user. Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be a big deal to include that file. Currently we are running ${PYTHON} -c "import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)" but I really want to run the tests in the same way as you are doing it.

  5. tacaswell commented on Jan 11, 2016

    @tacaswell
    Member

    Fair enough. I am biased towards pulling directly from the tag on gh as it
    is the ground truth, but I will not argue with packagers about packaging. (
    I was just trying to be helpful and suggest work arounds for right now).

    Unless this is a regression I don't think this is enough to force a new
    release, but will be fixed in the next one.

    On Mon, Jan 11, 2016, 07:56 Justin Lecher notifications@github.com wrote:

    Many downstream distro like fedora, debian, gentoo and so are using the
    pypi tarball, as this is what you are intending to ship to the end user.
    Therefor I rather dislike the idea to fetch directly from GH. Shouldn't be
    a big deal to include that file. Currently we are running ${PYTHON} -c
    "import sys, matplotlib as m; sys.exit(0 if m.test(verbosity=2) else 1)"
    but I really want to run the tests in the same way as you are doing it.

    —
    Reply to this email directly or view it on GitHub
    #5831 (comment)
    .

  6. jlec commented on Jan 11, 2016

    @jlec
    Author

    Unless this is a regression I don't think this is enough to force a new release, but will be fixed in the next one.

    no, that can be done in the next release. thanks.

  7. modified the milestones: , on Jan 12, 2016
  8. added a commit that references this issue on Jan 12, 2016
    f9f5452
  9. self-assigned this
    on Jan 12, 2016
  10. added a commit that references this issue on May 22, 2016
    41d7aa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions