Repository navigation
Several axes_grid1 and axisartist examples broken on master #5757
Description
There are not really any unittest that tests this functionality so this is not caught but the following examples have changes since 1.5.0
- inset_locator_demo1
1.5.0
Master
- inset_locator_demo2
1.5.0
Master
(http://matplotlib.org/devdocs/mpl_toolkits/axes_grid/examples/inset_locator_demo2.png)
- simple_axisline4
1.5.0
Master
- Simple anchored artists
1.5.0
Master
It's likely that this is only one or two issues.
Activity
jenshnielsen commentedon Dec 29, 2015
This was found doing #5752 Ironically #5752 fixes the issue with simple_axisline4 by changing the example from a axisartist axis to a regular matplotlib axis but that is of cause not a proper fix.
mdboom commentedon Dec 29, 2015
I can bisect to hopefully find the cause.
mdboom commentedon Dec 29, 2015
First bad commit is f88114c. I'm working on a solution.
mdboom commentedon Dec 29, 2015
simple_axisline4 was broken by d268abf (i.e. a different commit).
Fix matplotlib#5757: Fix axis_grid1 examples for recent chg
smheidrich commentedon Jul 31, 2016
@mdboom Is this change actually needed? If I remove the line on my system, the example image still comes out fine.
jenshnielsen commentedon Jul 31, 2016
@smheidrich Can you create a new issue detailing exactly which change you are referring too. The whole commit or a part of it. Commenting on a closed PR is sure to be lost in the noise.
smheidrich commentedon Jul 31, 2016
@jenshnielsen the link has an anchor that points to the exact line I mean (
examples/axes_grid/simple_axisline4.pyline 16):I don't think this is important enough to warrant a new issue, I just don't see why it is needed (works without it on my system). If it is needed then I must have seriously messed something up in #4898... there is another issue where it broke something so I feel responsible.
EDIT Nevermind actually, you wrote yourself that it was fixed by removing the
AA.Axesthing, so that's why it now works without it on my system. Still, the line should be removed IMHO if it's not needed.