Repository navigation
Change in colorbar extensions #5524
Description
In #5307, where I am lowering our testing tolerance down to zero, I am discovering a few recent changes that slipped through because the tolerance on our tests was too high.
In particular 8928311 introduced the following change in test_axes:test_contour_colorbar.
Current baseline image:
Current behavior after 8928311:
The test code:
@image_comparison(baseline_images=['contour_colorbar'])
def test_contour_colorbar():
x, y, z = contour_dat()
fig = plt.figure()
ax = fig.add_subplot(111)
cs = ax.contourf(x, y, z, levels=np.arange(-1.8, 1.801, 0.2),
cmap=plt.get_cmap('RdBu'),
vmin=-0.6,
vmax=0.6,
extend='both')
cs1 = ax.contour(x, y, z, levels=np.arange(-2.2, -0.599, 0.2),
colors=['y'],
linestyles='solid',
linewidths=2)
cs2 = ax.contour(x, y, z, levels=np.arange(0.6, 2.2, 0.2),
colors=['c'],
linewidths=2)
cbar = fig.colorbar(cs, ax=ax)
cbar.add_lines(cs1)
cbar.add_lines(cs2, erase=False)
@efiring: Do you know if this change was intentional?
Activity
efiring commentedon Nov 19, 2015
Not intentional. The problem is that contour is using np.inf and -np.inf as added levels with 'extend' in
_process_levels(). The simple solution is to use something like 1e300 and -1e300 instead.Fix matplotlib#5524. Use finfo.max instead of np.inf
Fix matplotlib#5524. Use finfo.max instead of np.inf
Merge pull request #5534 from mdboom/color-extensions
Merge pull request #5534 from mdboom/color-extensions
Revert "Fix #5524. Use finfo.max instead of np.inf"
Merge pull request #5544 from matplotlib/revert-5534-color-extensions
1 remaining item
mdboom commentedon Nov 23, 2015
#5546 is a solution based directly on @efiring's suggestion.
Fix matplotlib#5524: Use large, but finite, values
Fix matplotlib#5524: Use large, but finite, values
tacaswell commentedon Nov 30, 2015
Wait, what did I do?
mdboom commentedon Nov 30, 2015
I think this was a merging snafu (my fault). This was a commit that we later reverted, but it's still in there and when it was merged up closed this issue again.
Fix matplotlib#5524: Use large, but finite, values
Fix matplotlib#5524: Use large, but finite, values
Merge pull request #5546 from mdboom/color-extensions2