Limit what style.use can affect? #4855

Activity

1. tacaswell commented on Aug 3, 2015

   

   tacaswell

   on Aug 3, 2015

   Member

   More actions

   👍 from me.
2. tacaswell

   added

   API: default changesChanges to default behaviorChanges to default behavior

   on Aug 3, 2015
3. tacaswell

   added this to the Color overhaulThis milestone has been deleted milestone on Aug 3, 2015
4. efiring commented on Aug 3, 2015

   

   efiring

   on Aug 3, 2015

   Member

   More actions

   Offhand, such a limitation sounds to me like a good idea.

   On 8/3/15, Michael Droettboom notifications@github.com wrote:

   This might be a controversial proposal, so I thought I'd get some discussion
   first.

   In astropy, there is a "house style", which, surprising to me, included
   interactive: True. I wouldn't have expected a style to affect the
   interactive setting (which I see more as a user preference than affecting
   the style of the output). I'm going to advocate that astropy removes that
   but relatedly...

   Would it make sense to filter out rcParams that don't really relate to style
   in style.use? I realize this somewhat breaks DWIM, but it does prevent a
   certain kind of shooting oneself in the foot...

   ---

   Reply to this email directly or view it on GitHub:
   #4855
5. WeatherGod commented on Aug 3, 2015

   

   WeatherGod

   on Aug 3, 2015

   Member

   More actions

   others might be the backend, keymaps, etc. As I was making the "classic"
   style, I was conflicted in a few spots about what to explicitly set in the
   style. I may be a bit overzealous when I made it and it could be trimmed
   back before merging (once we figure out the whole font issue...).

   On Mon, Aug 3, 2015 at 10:36 AM, Eric Firing notifications@github.com
   wrote:

   Offhand, such a limitation sounds to me like a good idea.

   On 8/3/15, Michael Droettboom notifications@github.com wrote:

   This might be a controversial proposal, so I thought I'd get some
   discussion
   first.

   In astropy, there is a "house style", which, surprising to me, included
   interactive: True. I wouldn't have expected a style to affect the
   interactive setting (which I see more as a user preference than affecting
   the style of the output). I'm going to advocate that astropy removes
   that
   but relatedly...

   Would it make sense to filter out rcParams that don't really relate to
   style
   in style.use? I realize this somewhat breaks DWIM, but it does prevent
   a
   certain kind of shooting oneself in the foot...

   ---

   Reply to this email directly or view it on GitHub:
   #4855

   —
   Reply to this email directly or view it on GitHub
   #4855 (comment)
   .
6. dopplershift commented on Aug 3, 2015

   

   dopplershift

   on Aug 3, 2015

   Contributor

   More actions

   👍 Less foot shooting is a good thing.
7. mdboom

   modified the milestones: Color overhaulThis milestone has been deleted, next major release (2.0)This milestone has been deleted on Oct 8, 2015
8. mdboom

   self-assigned this

   on Nov 8, 2015
9. mdboom

   added a commit that references this issue on Nov 8, 2015

   Fix matplotlib#4855: Blacklist rcParams that aren't style

   This issue will close once commit c90bcfb is merged into the 'master' branch.

   c90bcfb
10. mdboom

    added

    status: needs review

    on Nov 8, 2015
11. mdboom

    closed this as completedin c90bcfbon Dec 31, 2015
12. efiring

    added a commit that references this issue on Dec 31, 2015

    Merge pull request #5440 from mdboom/blacklist-style-params

    ...

    This issue will close once commit 8decc8c is merged into the 'main' branch.

    8decc8c
13. mdboom

    removed

    status: needs review

    on Dec 31, 2015
14. jenshnielsen

    added a commit that references this issue on Jan 5, 2016

    Merge pull request matplotlib#5440 from mdboom/blacklist-style-params

    ...

    This issue will close once commit 4c319fc is merged into the 'master' branch.

    4c319fc