Skip to content

Docs require skimage #3685

Closed
Closed

Description

@mdboom

Three examples now require it, for the rgb2lab function:

users/plotting/colormaps/lightness.py
5:from skimage import color

users/plotting/colormaps/Lfunction.py
9:from skimage import color

users/plotting/colormaps/grayscale.py
6:from skimage import color

We should probably just subsume rgb2lab -- skimage is a fairly heavy dependency just for this.

Activity

  1. jenshnielsen commented on Oct 20, 2014

    @jenshnielsen
    Member

    Yes, I was trying to fix all the Sphinx warnings on Travis but never got round to this one. It is even more problematic since this part of skimage depends on scipy too.

    I was planing to just deploy the dependencies with miniconda, but skimage also depends on matplotlib so we could easily create circular dependencies.

  2. mdboom commented on Oct 20, 2014

    @mdboom
    MemberAuthor

    Yeah -- but for just converting RGB to LAB, we shouldn't need all that, see, for example:

    https://stackoverflow.com/questions/13405956/convert-an-image-rgb-lab-with-python

  3. jenshnielsen commented on Oct 20, 2014

    @jenshnielsen
    Member

    Cool that is probably a better solution given the issues above.

  4. added this to the milestone on Oct 20, 2014
  5. jenshnielsen commented on Nov 10, 2014

    @jenshnielsen
    Member

    fixed by #3737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions