You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since PR #3067 I am unable to build from source (under windows).
This PR added a get_extension method to class FreeType in setupext.py.
A easy workaround is to explicitly return the default None under windows platform, but this seems a bit dirty.
I can confirm the build issue and that the fix works with msvc. It looks to me that building a dummy C extension without source files is "undefined" and could also break with other compilers/linkers (?).
Unfortunately due to a recent "flooding" issue with my home computer, I
will be unable to submit it in the next few weeks.
Please, feel free to go on and merge the proposed patch if you wish.
Activity
pelson commentedon Jun 18, 2014
Thanks @GBillotey.
@cgohlke - just wondering if you have any thoughts on this?
cgohlke commentedon Jun 18, 2014
I can confirm the build issue and that the fix works with msvc. It looks to me that building a dummy C extension without source files is "undefined" and could also break with other compilers/linkers (?).
pelson commentedon Jun 25, 2014
@GBillotey - over to you if you're happy to submit a PR?
GBillotey commentedon Jun 25, 2014
Unfortunately due to a recent "flooding" issue with my home computer, I
will be unable to submit it in the next few weeks.
Please, feel free to go on and merge the proposed patch if you wish.
2014-06-25 16:48 GMT+02:00 Phil Elson notifications@github.com:
BLD : fix build on windows