Repository navigation
[MNT]: Scale val_in_range method #31286
Description
Summary
From @timhoffm's comment: #31061 (comment)
Should we grow a method
Scale.val_in_range(val). This seems like a logically meaningful API.ScaleBasecould implement this as a generic fallback vialimit_range_for_scaleto support existing third-party scales. But specific scales could implement their logic much more efficiently; e.g.LinearScalewould just returnTrue, andLogScalewould returnval > 0.
Should be cleaner logic and faster computation.
Proposed fix
Implement and update Axes._point_in_data_domain to use it.
Activity
[-][MNT]: Scale.val_in_range method[/-][+][MNT]: Scale `val_in_range` method[/+]null-dreams commentedon Mar 14, 2026
Hi @scottshambaugh! I would like work on this fix if it's still open.
I have implemented
val_in_rangeinScaleBasewith a fallback and added optimized overrides inLinearScale,LogScaleandLogitScale. I have also refactored_point_in_data_domainto use this new change. I'll open a draft PR shortly. I would appreciate any guidance regarding documentation and docstring updates. Thank you.