Add warning to get_window_extent #3055

Activity

1. tacaswell

   added this to the v1.4.0 milestone on May 9, 2014
2. tacaswell

   added

   doc

   on May 9, 2014
3. pelson commented on May 20, 2014

   

   pelson

   on May 20, 2014

   Member

   More actions

   I'm not sure I agree with this. Adding the warning will not give us anything new, other than an annoying warning. A known bug doesn't necessarily have to emit a warning as far as I'm concerned...
4. efiring commented on May 20, 2014

   

   efiring

   on May 20, 2014

   Member

   More actions

   @pelson, I think @tacaswell is suggesting a warning somewhere in the documentation, not a warning to be emitted by the code.
5. tacaswell commented on May 20, 2014

   

   tacaswell

   on May 20, 2014

   MemberAuthor

   More actions

   Yes, I mean to put a note in the documentation, not to emit a warning.
   On May 20, 2014 2:04 PM, "Eric Firing" notifications@github.com wrote:

   @pelson https://github.com/pelson, I think @tacaswellhttps://github.com/tacaswellis suggesting a warning somewhere in the documentation, not a
   warning to be emitted by the code.

   —
   Reply to this email directly or view it on GitHubhttps://github.com//issues/3055#issuecomment-43661948
   .
6. tacaswell commented on May 21, 2014

   

   tacaswell

   on May 21, 2014

   MemberAuthor

   More actions

   Also, this issue my be unneeded if the patch from @leejjoon in PR #3054 cleans up all of these issues.

   It is easier to do-in an extra issue than remember one that does not exist 😉
7. pelson commented on May 21, 2014

   

   pelson

   on May 21, 2014

   Member

   More actions

   Ah. Thanks @tacaswell & @efiring - got the wrong end of the stick. 👍 after all 😉
8. tacaswell

   added a commit that references this issue on Jul 4, 2014

   DOC : added warning to doc of get_window_extent

   ...

   This issue will close once commit 244dd18 is merged into the 'main' branch.

   244dd18
9. tacaswell

   added

   has_patch

   and removed

   needs_patch

   on Jul 4, 2014
10. dmcdougall

    closed this as completedin #3184on Jul 11, 2014
11. joferkington

    added a commit that references this issue on Jul 23, 2014

    DOC : added warning to doc of get_window_extent

    ...

    This issue will close once commit 423222d is merged into the 'master' branch.

    423222d