-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Open
Description
Summary
- The change that broke [Bug]: title position incorrect for polar plot #29381 would have been fine if the logic that calculates
topwithinAxes._update_title_positiononly needed to work for ordinaryAxesinstances. - Cartopy has artists separate from the
XAxisandYAxiswhich must be considered for title placement. Currently, it does that by overriding_update_title_position. Overriding a private method is not ideal, neither is repeating some of the code that is already in the parent method.
Proposed fix
Factor out a public method that returns top. Making it public means it can safely be overridden in subclasses such as PolarAxes and Cartopy's GeoAxes. Knowing it can/should be overridden in subclasses means that in the parent Axes we can use the most efficient approach that works for Axes.
story645