add ccw pie test #2897

Activity

1. tacaswell

   added this to the v1.4.0 milestone on Mar 13, 2014
2. tacaswell

   added

   needs_patch

   on Mar 13, 2014
3. tacaswell

   self-assigned this

   on Mar 13, 2014
4. sfroid commented on Mar 26, 2014

   

   sfroid

   on Mar 26, 2014

   Contributor

   More actions

   @tacaswell
   Thomas... are we looking for an image test for this one?
   Also, from the other pie based bug I wrote tests for (#2923), you commented that we might only need a png test and can ignore the svg and pdf files.

   How do I ignore the svg/pdf files? Can I just leave them out from the commit? Wouldn't that lead to failed tests?
5. tacaswell commented on Mar 26, 2014

   

   tacaswell

   on Mar 26, 2014

   MemberAuthor

   More actions

   Yes, we are looking for an image test here.

   You can specify which extensions to test by passing the extensions kwarg to the decorator:

   @image_comparison(..., extensions=['png'])
   def test_blah(..)
        pass
   

   See the function in testing.decorators for all of the parameters.
6. sfroid

   added a commit that references this issue on Mar 28, 2014

   matplotlib#2897 changing comment for the pie clockwise test

   bf1216c
7. sfroid commented on Mar 28, 2014

   

   sfroid

   on Mar 28, 2014

   Contributor

   More actions

   @tacaswell
   I started creating the tests but then I thought I made an error, where I branched the fix off the master. I believed that I should have branched it off 1.4.0 or 1.4.x. Then I noticed that there is no 1.4.0 or 1.4.x branch. Should I branch off the master?
8. tacaswell commented on Mar 28, 2014

   

   tacaswell

   on Mar 28, 2014

   MemberAuthor

   More actions

   Yes, work off of master. We have not cut 1.4 yet.
9. sfroid

   added a commit that references this issue on Mar 28, 2014

   matplotlib#2897 removing ccw=false test

   8a6f779
10. tacaswell

    closed this as completedin 998676aon Mar 28, 2014
11. anntzer

    removed

    status: needs patch

    on Jul 12, 2018