Skip to content

merging 1.3.x broke build on master #2878

Closed

Description

@tacaswell

The issues is with matplotlib.tests.test_streamplot.test_streamplot_limits and matplotlib.tests.test_collections.test_barb_limits which passed on 1.3.x before the merge.

@pelson Can you take a look at this?

Related to #2444

Activity

  1. added this to the v1.4.0 milestone on Mar 8, 2014
  2. pelson commented on Mar 10, 2014

    @pelson
    Member

    @pelson Can you take a look at this?

    Sure.

    Looks like the numbers are pretty close:

    Arrays are not almost equal to 2 decimals
    
    (mismatch 25.0%)
     x: array([ 19.99259073,  29.99042969,  15.01481855,   6.01914062])
     y: array([20, 30, 15,  6])
    

    Dropping this from 2 decimals to 1 would be sufficient - the fact is that streamplot will not result in exact limits as it is the extents of the resulting paths which are used, not the input data itself.

    The same issue applies to the barb test.

  3. tacaswell commented on Mar 10, 2014

    @tacaswell
    MemberAuthor

    Merged the PR, but I am still a bit concerned that it passed on 1.3.x before the merge, but not on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions