Skip to content

Size hint method in Qt backend should be named minimumSizeHint, not minumumSizeHint #28716

Closed

Description

@mikhas

def minumumSizeHint(self):

Activity

  1. added this to the v3.9.3 milestone on Aug 15, 2024
  2. added
    🌱 Good first issueOpen a pull request against these issues if there are no active ones!
    on Aug 15, 2024
  3. github-actions commented on Aug 15, 2024

    @github-actions

    Good first issue - notes for new contributors

    This issue is suited to new contributors because it does not require understanding of the
    Matplotlib internals. To get started, please see our contributing
    guide
    .

    We do not assign issues. Check the Development section in the sidebar for linked pull
    requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please
    collaborate on the work by reviewing it rather than duplicating it in a competing PR.

    If something is unclear, please reach out on any of our communication
    channels
    .

  4. tacaswell commented on Aug 15, 2024

    @tacaswell
    Member

    task:

    • correct spelling of method name so Qt will use it!
  5. tacaswell commented on Aug 15, 2024

    @tacaswell
    Member

    This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors

  6. tacaswell commented on Aug 15, 2024

    @tacaswell
    Member
  7. mikhas commented on Aug 15, 2024

    @mikhas
    Author

    This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors

    I can't even tell what the effect is, given that the intended minimum size of width=10, height=10 appears to be too small (to me) anyway.

  8. tacaswell commented on Aug 15, 2024

    @tacaswell
    Member

    We had a number of issues where we would end up with 0 pixel sized widgets that lead to crashes in the rasterizer. I suspect that the intent of the minimumSizeHint is to make sure Qt never squashes the widget all they way to 0 so the figure is always technically render able (if useless).

    Given it has never worked, and we have other fixes for the issues it being missing caused, just removing it is also an option. However, I still lean towards "fix it".

  9. QuLogic commented on Aug 16, 2024

    @QuLogic
    Member

    Fixed by #28732.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🌱 Good first issueOpen a pull request against these issues if there are no active ones!

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions