You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Size hint method in Qt backend should be named minimumSizeHint, not minumumSizeHint #28716
This issue is suited to new contributors because it does not require understanding of the
Matplotlib internals. To get started, please see our contributing
guide.
We do not assign issues. Check the Development section in the sidebar for linked pull
requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please
collaborate on the work by reviewing it rather than duplicating it in a competing PR.
We had a number of issues where we would end up with 0 pixel sized widgets that lead to crashes in the rasterizer. I suspect that the intent of the minimumSizeHint is to make sure Qt never squashes the widget all they way to 0 so the figure is always technically render able (if useless).
Given it has never worked, and we have other fixes for the issues it being missing caused, just removing it is also an option. However, I still lean towards "fix it".
Activity
github-actions commentedon Aug 15, 2024
Good first issue - notes for new contributors
This issue is suited to new contributors because it does not require understanding of the
Matplotlib internals. To get started, please see our contributing
guide.
We do not assign issues. Check the Development section in the sidebar for linked pull
requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please
collaborate on the work by reviewing it rather than duplicating it in a competing PR.
If something is unclear, please reach out on any of our communication
channels.
tacaswell commentedon Aug 15, 2024
task:
tacaswell commentedon Aug 15, 2024
This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors
tacaswell commentedon Aug 15, 2024
qt docs: https://doc.qt.io/qt-6/qwidget.html#minimumSizeHint-prop
mikhas commentedon Aug 15, 2024
I can't even tell what the effect is, given that the intended minimum size of
width=10,height=10appears to be too small (to me) anyway.tacaswell commentedon Aug 15, 2024
We had a number of issues where we would end up with 0 pixel sized widgets that lead to crashes in the rasterizer. I suspect that the intent of the minimumSizeHint is to make sure Qt never squashes the widget all they way to 0 so the figure is always technically render able (if useless).
Given it has never worked, and we have other fixes for the issues it being missing caused, just removing it is also an option. However, I still lean towards "fix it".
Renamed the minumumSizeHint method to minimumSizeHint according to ma…
QuLogic commentedon Aug 16, 2024
Fixed by #28732.