Repository navigation
[Bug]: Savefig with invalid filename #27748
Description
Bug summary
savefig returns no error when using invalid filename
Code for reproduction
import matplotlib.pyplot as plt
import numpy as np
x = np.linspace(0, 10, 100)
y = np.sin(x)
plt.figure(figsize=(8, 6))
plt.plot(x, y, '-r', label='Sinewave')
plt.title('Example')
plt.xlabel('X-axis')
plt.ylabel('Y-axis')
plt.legend(loc='best')
# creates empty file named test - no error thrown
plt.savefig('test : diagramm')Actual outcome
no error message - only empty file which is a little bit confusing as there is no error message created
Expected outcome
Thrown Exception: Invalid Filename
Additional information
No response
Operating system
Windows 10 Professional
Matplotlib Version
3.8.2
Matplotlib Backend
No response
Python version
3.11.6
Jupyter version
No response
Installation
pip
Activity
rcomer commentedon Feb 5, 2024
For me on Ubuntu with TkAgg this code saves out an image with filename
test : diagramm.png. The image itself is as you would expect from the code.timhoffm commentedon Feb 5, 2024
Might be a windows topic since
:is not allowed there.tacaswell commentedon Feb 5, 2024
what does
do?
QuLogic commentedon Feb 5, 2024
:is not technically barred on Windows, since maybe NT? The above test code works fine.However, the file is not usable in Explorer. It appears as
test, so if you try to open or delete it, it doesn't work. It's also not accessible from PowerShell or the Command Prompt. That's not actually because of the colon, but because the filename ends with a space, which is not allowed. Whileos.unlink('test ')did seem to work, it seems to be stuck in the system somewhere and still shows up indiror Explorer but can't be opened any more.What the colon actually does is open an NTFS Alternate Data Stream, and that is intentional. If you remove the space before the colon, then everything works a bit more reasonably:
QuLogic commentedon Feb 5, 2024
Weirdly, if you have just this invalid filename-ending-in-space, then you can't see it correctly with
dir /R(you only seetestitself), but if you create a valid one astest:broken, then you can see both correctly:That is, you can see both of them and their Alternate Data Streams.
And it seems
del "test*"is able to delete them both.timhoffm commentedon Feb 6, 2024
Seems not exactly true. It's allowed but not fully supported 🙄 : https://stackoverflow.com/a/67886889
Edit: Official win32 docs say:
Handling this is beyond our responsibility. This should be reported upstream and cpython itself should decide whether they act on it.
timhoffm commentedon Feb 8, 2024
I'm closing this as we're not going to do any special casing on the Matplotlib side. This is up to cpython: python/cpython#115104.