Repository navigation
[Bug]: ContourLabeler.clabel with manual != False breaks unconnected contours #27062
Description
Bug summary
When adding contour label positions manually (either via clicking or specifying an iterable of positions), contours with disconnected parts are not handled correctly, but sometimes rejoined seemingly arbitrarily.
Code for reproduction
import matplotlib.pyplot as plt
import numpy as np
fig, ax = plt.subplots()
x, y = np.mgrid[-1:1:21j, -1:1:21j]
cs = ax.contour(x, y, 1/np.sqrt(0.01+(x+0.3)**2+y**2) + 1/np.sqrt(0.01+(x-0.3)**2+y**2), levels=[7])
cs.clabel(manual=[(0.2, 0.1)])Actual outcome
Expected outcome
As it looked in matplotlib 3.7.3:
Additional information
No response
Operating system
No response
Matplotlib Version
3.8.0
Matplotlib Backend
No response
Python version
No response
Jupyter version
No response
Installation
conda
Activity
jklymak commentedon Oct 11, 2023
Did this break, or did it never work?
rho-novatron commentedon Oct 11, 2023
It looks correct in 3.7.3. I updated the "expected outcome" screenshot from that.
rho-novatron commentedon Oct 11, 2023
It is also still broken in main now (6501209 )
ksunden commentedon Oct 11, 2023
I was able to fix this with a one line change, there was a line that struck me as possibly wrong when looking into #26971, but it was not related to that one, and was instead related to this bug. I'll add it to #27045
Only rotate the subsection of the Path
rho-novatron commentedon Oct 11, 2023
Yay - the one-liner works for me. Thanks!